fix: use CRP defaulter to account for nil CRP policy in eviction controller #987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arvindthiru
changed the title
jwtty
reviewed
Dec 11, 2024
michaelawyu
reviewed
Dec 12, 2024
michaelawyu
previously approved these changes
Dec 12, 2024
Arvindthiru
changed the title
| }, | ||
| }, | ||
| }, | ||
| crp: ptr.To(buildTestPickAllCRP(testCRPName)), |
Contributor
There was a problem hiding this comment.
I wonder why sometimes we use this while sometimes we just use testCRP
Contributor
Author
There was a problem hiding this comment.
testCRP is only used for validateEviction test where we use defaulter to set default values on the CRP. For all the other tests we can build CRP which doesn't need to have all default values
zhiying-lin
reviewed
Dec 13, 2024
pkg/controllers/clusterresourceplacementeviction/controller_test.go
Outdated
Show resolved
Hide resolved
ryanzhang-oss
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer